[#20] Task 등록, 수정, 삭제 기능에 Reminder 설정 기능 추가 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Oct 10, 2024
| .build(); | ||
| } | ||
|
|
||
| public void updateLastReminderSentTime(LocalDateTime lastReminderSentTime, ClockHolder clockHolder) { |
There was a problem hiding this comment.
저 예전부터 궁금하던게 있는데요. clockHolder는 어떤 역할을 하는 것인가요?
f-lab-lyan
reviewed
Oct 10, 2024
|
|
||
| @RequiredArgsConstructor | ||
| @Service | ||
| public class ReminderNotificationService { |
There was a problem hiding this comment.
이 로직은 좀 더 고민해보고, 어떻게 할지 생각해보죠. :-)
There was a problem hiding this comment.
넵 지난시간에 말씀해주신 방법과 함께 고민해보겠습니다 ㅎㅎ
f-lab-lyan
reviewed
Oct 10, 2024
| Assertions.assertTrue(reminderSettings.isReminderDue(new TestClockHolder(currentDateTime))); | ||
| }, | ||
| () -> { | ||
| LocalDateTime currentDateTime = taskStartDateTime.plusMinutes(3); |
|
리뷰감사합니당 ㅎㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배경
알림 요구사항
변경 내용
참고내용
이전 리뷰내용과 ClockHolder 내용은 아직 반영 전입니다..! 이번주중에 나누어서 반영하도록 하겠습니다. 🙂